https://gitlab.synchro.net/main/sbbs/-/commit/0e6853aeef28d32a26bc2c46
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Correctly support 1,000 arguments to an external

Previously, more than 999 arguments would overrun a buffer and break
things.

Fixes CID 33313

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7505f317f5581340ed1a9f60
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix use of uninitialized local variable (err_pipe[]) on *nix

And other weirdness around EX_NOLOG mode checks.
Addresses Coverity-scan CID 330048.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9445866c80a38b5ee6c170ea
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Ignore VDD WriteFile() failures if the child process has terminated

If the child process (e.g. door game) has terminated, don't log errors if/when WriteFile() to the mailslot fails. This would be expected as the mailslot is created/owen-by sbbsexec.dll which would also terminate along with the process, thus closing the mailslot.

Hopefully resolves the errors reported by DesotoFireflite (VALHALLA).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/08ce315f97a09569f169ef89
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Suppress "VDD Open failed" warning if child process terminated

Another log message reported by DesotoFireflite (VALHALLA) that can happen when a user has typed something while the programming is running and the program terminates before the data can be sent to it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/47e604723eb6eb602ed7e463
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn

We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program (e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows wouldn't work right in the scenario anyway even if it did load successfully.

This resolves the reported issues with timed events configured as not "native" returning error 255 (and not running successfully) on Windows with SBBS v3.19. I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN to run offline DOS programs) really shouldn't have been attempted in the first place. So that was just a design issue that happened to kind of sort of work up until v3.19.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e54263fde0be580dcbaf77c8
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Log command-line that led to logged error opening DOSXTRN.RET

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76fa22e427a7b9978084bf94
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Remove lprintf() call from child process of fork() call on *nix

the info-level debug message "Detaching external process"... as this appears
to be the cause of background events hanging sometimes, on Linux (at least).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fd2a8b605803259ceb974d49
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Add node interrupt flag checking to *nix external() execution of stdio progs

and abort the execution of the program when the node is interrupted. This should allow more cases were the node interrupt flag can be used to gracefully disconnect a user running a DOS or native (stdio) program on *nix.

We have this functionality already in the Windows version of external()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net